@johnjohnson55 Maybe. Not going through all of that. Gain/loss is based on your ACB, so if that is what you are calculating there, then good, otherwise https://www.adjustedcostbase.ca/
Exchange rates for investments are based on the daily rate (or actual) on the day there is a transaction.